Repository navigation
fix: do not suggest a hidden help command - #2552
Open
ruziba3vich wants to merge 1 commit into
Open
ruziba3vich wants to merge 1 commit into
ruziba3vich wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
suggestCommandaddshelpandhto the names of every command it looks at:When the help command is visible it is already in the command list, so the append changes nothing. When it is hidden (
HideHelpCommandorHideHelp), the function can return a command that does not exist.With
PrefixMatchCommandsthis stops a real command from running:suggestCommandreturnshelpforhel(andhforh),Command("help")finds nothing, andhellois not run.suggestions.go: iterate overcommand.Names()only.suggestions_test.go: one test forsuggestCommandwithout a help command in the list, one for thePrefixMatchCommands+HideHelpCommandrun.suggestFlagalready takes ahideHelpargument for the same reason.Which issue(s) this PR fixes:
None, I did not find an existing issue for this.
Testing
Both new tests fail on
main(expected: "hello",actual: "help") and pass with the change.go test ./...passes. I did not runmake(nogfmruninstalled); the change does not touch the public API.Release Notes
🤖 Generated with Claude Code