fix: make cli compatible with kernel changes - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CLI to be compatible with recent kernel changes by replacing the deprecated Interpreter and Runtime classes with the new unified Kernel class. The changes simplify the code structure while maintaining the same functionality.
Key changes:
- Replace
InterpreterandRuntimewith unifiedKernelclass - Update event listener names to match new kernel API
- Remove redundant message state updates
| }); | ||
| }, []); | ||
|
|
||
| function sendMessage(msg: Message) { |
There was a problem hiding this comment.
The setMessages call was removed from sendMessage function, but it's still present in the message event handler. This creates inconsistent state update patterns - messages are only updated when the kernel emits an event, not immediately when sending. Consider if immediate state update is needed for better UX.
Suggested change
| function sendMessage(msg: Message) { | |
| function sendMessage(msg: Message) { | |
| setMessages((prevMessages) => [...prevMessages, msg]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.