Skip to content

Add support for 2D profiles#195

Open
samueljackson92 wants to merge 19 commits into
devfrom
slj/profile2d
Open

Add support for 2D profiles#195
samueljackson92 wants to merge 19 commits into
devfrom
slj/profile2d

Conversation

@samueljackson92

Copy link
Copy Markdown
Contributor

This pull request introduces the ability to annotate different types of 2D profiles with bounding box and polygon annotations.

  • Added the ability create bounding box and polygon annotations
  • Added the ability to manipulate (delete, change type of) annotations on spectrogram view.
  • Refactored threshold annotator to output lists of PolygonAnnotation objects instead of masks

@samueljackson92 samueljackson92 added the enhancement New feature or request label Mar 4, 2026
@samueljackson92 samueljackson92 changed the title Add support for 2D profiles [WIP] Add support for 2D profiles Mar 4, 2026
@samueljackson92 samueljackson92 marked this pull request as draft March 4, 2026 11:43
@samueljackson92 samueljackson92 changed the base branch from main to dev April 1, 2026 08:12
@samueljackson92 samueljackson92 marked this pull request as ready for review April 1, 2026 08:57
@samueljackson92 samueljackson92 changed the title [WIP] Add support for 2D profiles Add support for 2D profiles Apr 1, 2026
samueljackson92 and others added 9 commits June 3, 2026 11:03
- Fix MongoDBClient to check url (not db_name) for mongodb:// prefix,
  so the server uses the real MongoDB when MONGO_URL is configured.
  This was causing test isolation to break: the server used a file-based
  Mongita DB while server_setup teardown dropped the MongoDB container,
  leaving stale data between tests.
- Update test_sample_view_page column header assertions to match the
  redesigned annotations table (Type/Label/Position vs Category/Type/Data).
- Update test_timeseries_page position-column index (nth(2)→nth(3)) and
  parsing to match the new labeled format ("Time: X.XX" and
  "Time Min: X.XX, Time Max: Y.YY").

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
React Spectrum's TableView renders the first column cell as role="rowheader"
rather than role="gridcell". The 4-column annotations table (Type/Label/
Created By/Position) therefore has 3 gridcells per row, with Position at
nth(2), not nth(3). The previous fix incorrectly changed nth(2) to nth(3),
causing timeouts waiting for a 4th gridcell that never appears.

Also increase CI pytest timeout from 15 to 30 minutes so the full
unit + E2E suite has room to complete.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- round(time, 4) != float(toFixed(2)) — use round 2 to match UI display
- Increase model training "completed" timeout from 30s to 90s so tests
  don't fail when the Ray worker environment initialises on cold start

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@samueljackson92 samueljackson92 self-assigned this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants