Allow Generated Mocks to Accept Other Mock Interfaces as Input to Avoid Cyclic Imports #208

Activity

1. kAvEh--

   changed the title [-]Generated Mocks in Separate Package Cause Cyclic Import When Used in Main Package[/-] [+]Allow Generated Mocks to Accept Other Mock Interfaces as Input to Avoid Cyclic Imports[/+] on Oct 2, 2024
2. tulzke commented on Oct 2, 2024

   

   tulzke

   on Oct 2, 2024

   Contributor

   More actions

   Here is a simple example why this does not work:
   example.zip

   TL;DR:
   // compilation error
   // Type HumanMock does not implement Human
   // need the method: Call(dog Dog)
   // have the method: Call(_ DogMock)
   var human Human = mock.HumanMock{}
3. tulzke commented on Oct 2, 2024

   

   tulzke

   on Oct 2, 2024

   Last edited by tulzke

   Contributor

   More actions

   Possible solutions to the problem:

   1. Generate mocks to the same directory as interfaces.
   2. Use the _test postfix for package in tests. Then the dependency graph will look like this:

   flowchart LR
   
   some_package
   mock --> some_package
   some_package_test --> some_package
   some_package_test --> mock
   

   Loading

   👍React with 👍1Reacted by Kaveh Fazaeli
4. uber-go

   locked and limited conversation to collaborators on Oct 15, 2024
5. JacobOaks

   converted this issue into a discussion #212 on Oct 15, 2024