Skip to content

fix(onboarding): Reject folders that aren't Git repositories - #728

Merged
Ziinc merged 1 commit into
mainfrom
ccr-001ba417-xtamiu-reject-non-git-folder
Oct 9, 2026
Merged

Ziinc merged 1 commit into
mainfrom
ccr-001ba417-xtamiu-reject-non-git-folder

Conversation

@Ziinc

@Ziinc Ziinc commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator
  • Opening a folder without .git created .treq/ in it, returned Ok(false), and opened it anyway as a broken repo
  • core::init now fails with a typed InitError::NotGitRepository before writing anything; the open flow shows " is not a Git repository…" and doesn't save it as last opened
  • Valid repos (and existing jj-only ones) behave as before; new Rust and NAPI integration tests cover the rejection
    🤖 Generated with Claude Code
    https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
    Generated by Claude Code

Opening a folder without a .git directory used to create .treq/ in it,
report Ok(false) from init, and open the folder as a repository. core::init
now returns InitError::NotGitRepository before writing anything, and the
open flow shows "<path> is not a Git repository. Open a folder that
contains a .git directory." without saving the path as last opened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
@Ziinc Ziinc changed the title Reject folders that aren't Git repositories on open fix(onboarding): Reject folders that aren't Git repositories Oct 5, 2026
@Ziinc
Ziinc merged commit b9f07ff into main Oct 9, 2026
25 of 26 checks passed
@Ziinc
Ziinc deleted the ccr-001ba417-xtamiu-reject-non-git-folder branch October 9, 2026 14:46

This branch was successfully deployed

1 active deployment
preview — e5f901af Deployed Oct 5, 2026 by Ziinc via build #1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants