Repository navigation
docs: Honour ?redirect= on sign-in and keep web sign-ins on the web - #716
Merged
Merged
Conversation
/sign-in now carries a validated redirect target through OAuth, email sign-in and sign-up. /auth/callback sends web sign-ins to that target (default /dashboard) and only creates a desktop token and opens treq:// when source=desktop. Only same-origin paths are accepted. The GitHub and Linear callbacks now pass a relative path so the round trip validates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
github-actions
Bot
changed the title
Contributor
|
🚀 Web preview: https://preview-716.treq-9zy.pages.dev |
… URLs The e2e lint requires specs to start at / and navigate through the UI. The callback pages have no UI route, so their decisions move into pure helpers (signInCallbackQuery, authCallbackDestination, signInHrefFor) that the spec tests directly, plus one browser test from the navbar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
Ziinc
pushed a commit
that referenced
this pull request
Oct 9, 2026
#716 is on main, so /auth/callback sends a web sign-in back to the ?redirect= target. The test no longer accepts a detour through /. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/sign-incarries a validated?redirect=through OAuth and email sign-in, so the GitHub App install and the alpha waitlist return users where they started/auth/callbacksends web sign-ins to that target (default/dashboard); it creates a desktop token and openstreq://only forsource=desktop🤖 Generated with Claude Code
https://claude.ai/code/session_01V9MDdxQJAhjXsAKyCpVwwt
Generated by Claude Code