Repository navigation
Fix fflush(NULL) to flush all output streams - #266
Conversation
tyfkda
left a comment
tyfkda
left a comment
There was a problem hiding this comment.
Thanks for fixing the missing part of the specification.
Could you also add a leading underscore to the flush_opened_files function name, remove the static keyword, and make sure the destructor has a void return type?
| result = EOF; | ||
| if ((stderr->flush)(stderr) != 0) | ||
| result = EOF; | ||
| for (int i = 0, len = __fileman.length; i < len; ++i) { |
There was a problem hiding this comment.
There is already a function in _fileman.c that performs similar operations. Could you modify this to call that function instead?
There was a problem hiding this comment.
Thanks for the review, I hadn't noticed that function. I made the requested changes and also added a test case. Is it now implemented as you intended?
tyfkda
left a comment
tyfkda
left a comment
There was a problem hiding this comment.
Sorry for the minor nitpick, but could you move the function prototype from _fileman.h to _file.h?
|
No problem, done! |
Per C11 7.21.5.2p2; previously it segfaulted on NULL.
|
Thanks! |
2 participants
Per C11 7.21.5.2p2, fflush(NULL) must flush all output streams. Previously it dereferenced NULL and segfaulted. Now it flushes stdout/stderr explicitly (statically allocated, not tracked in __fileman), returning EOF if either fails, and reuses the exit-time destructor _flush_opened_files for the remaining tracked files. Includes a fflush_null regression test.