ci: make CI green - #24
Merged
Merged
Conversation
- Add permissions: contents: read (least-privilege GITHUB_TOKEN)
- Add persist-credentials: false to all checkout steps
- Add concurrency group to cancel superseded CI runs
- Fix pre-release-hook: use --tag v{{version}} instead of --latest
(--latest resolves the previous tag since the new tag doesn't exist
yet during cargo-release's pre-release-hook)
- Run cargo fmt to fix formatting - Fix or allow pre-existing clippy warnings (dead_code, unused_variables, result_large_err, etc.) to unblock -D warnings gate
set_fixed_channel called std::os::unix::fs::symlink unconditionally, so the crate failed to compile on windows-latest (E0433: could not find `unix` in `os`). Gate the call per platform and use symlink_dir on Windows. Windows models a symlink-to-directory as a directory entry, so the removal of an existing link needs remove_dir rather than remove_file — otherwise the path would compile but fail at runtime when switching channels. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes formatting and clippy issues surfaced by the new CI workflow introduced in the previous hardening PR.
cargo fmtto fix formattingdead_code,unused_variables,result_large_err, etc.) to unblock the-D warningsgatepermissions: contents: read(least-privilegeGITHUB_TOKEN)persist-credentials: falseon all checkout stepsconcurrencygroup to cancel superseded CI runs--tag v{{version}}instead of--latestin pre-release-hook