Fix edge metadata key when cloning - #153
Open
silas-martens wants to merge 2 commits into
Open
Conversation
pearzt
approved these changes
Sep 1, 2026
pearzt
left a comment
Member
There was a problem hiding this comment.
LGTM. I'm surprised that this was not caught by tests. Could you take a look into the tests and make sure this is covered?
Member
|
It is a shame, that C++ does not support covariant return-types for unique_ptr specializations. If you are able to add a test, this looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merging edge metadata,
clone()returns astd::unique_ptr<MetaData>. Consequently, template argument deduction foraddEdgeMetaData()selectsT = MetaData, causingT::keyto resolve toMetaData::key("BaseClass") rather than the key of the dynamic metadata type.I noticed this when
cgmerge2changed stored my previously correct metadata under the"BaseClass"key.I fixed this, by using the virtual
getKey()method when inserting edge metadata.