Skip to content

build: Update C++ standard from c++17 to c++20 - #210

Merged
mc-nv merged 2 commits into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20
Sep 11, 2026
Merged

mc-nv merged 2 commits into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20

Conversation

@mc-nv

@mc-nv mc-nv commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • CMakeLists.txt

Test plan:

  • CI Pipeline ID: 67062220

Caveats:

This is the confirmed root cause repo — ATen.h now hard-errors below C++20 (see TRI-1877 description). Directly fixes the failing py3-base/*-rhel/-sbsa CI jobs.

Background

Part of a coordinated C++17->C++20 bump across ~18 Triton component repos (TRI-1877), triggered by upstream PyTorch's ATen.h now requiring C++20.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Resolves: TRI-1877

Upstream PyTorch raised ATen's minimum required C++ standard from 17
to 20 (pytorch/pytorch#178150), which broke the pytorch_backend build.
Align this repo's TRITON_MIN_CXX_STANDARD/CMAKE_CXX_STANDARD default
with that floor for consistency across the stack.

TRI-1877
@mc-nv mc-nv self-assigned this Sep 9, 2026
@mc-nv mc-nv added the build Build system or external dependencies (build: PRs) label Sep 9, 2026
This was referenced Sep 9, 2026
@mc-nv
mc-nv marked this pull request as ready for review September 10, 2026 15:27
@greptile-apps

greptile-apps Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the CMake logic now consistently enforces C++20 for default and stale-cache builds.

Summary

  • Raises stale cached standards below 20 to the new minimum.
  • Preserves valid user overrides requesting a standard higher than C++20.
  • Fully addresses the previously reported stale-cache behavior.

Reviews (2) · Last reviewed commit: "fix: raise stale cached TRITON_MIN_CXX_S..."

Comment thread CMakeLists.txt Outdated

@mattwittwer mattwittwer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mc-nv
mc-nv merged commit 8c64f65 into main Sep 11, 2026
2 checks passed
@mc-nv
mc-nv deleted the mchornyi/TRI-1877/TRI-1855-std-20 branch September 11, 2026 03:15
mc-nv added a commit that referenced this pull request Sep 11, 2026
* build: Update C++ standard from c++17 to c++20

Upstream PyTorch raised ATen's minimum required C++ standard from 17
to 20 (pytorch/pytorch#178150), which broke the pytorch_backend build.
Align this repo's TRITON_MIN_CXX_STANDARD/CMAKE_CXX_STANDARD default
with that floor for consistency across the stack.

TRI-1877

* fix: raise stale cached TRITON_MIN_CXX_STANDARD to the new C++20 floor

(cherry picked from commit 8c64f65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependencies (build: PRs)

Development

Successfully merging this pull request may close these issues.

2 participants