Skip to content

build: Fix manylinux Python version (#204) - #209

Merged
mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1691/before-ngc-release-advance-master-branch-to-next-upstream-release
Sep 2, 2026
Merged

mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1691/before-ngc-release-advance-master-branch-to-next-upstream-release

Conversation

@mc-nv

@mc-nv mc-nv commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

  • Carries the manylinux Python version fix forward from r26.08 onto main.
  • Straight cherry-pick of 1fbcecbf; no edits beyond the original.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

CMakeLists.txt — the two-line version fix.

Test plan:

  • Full CI run on the internal pipeline at TRITON_CONTAINER_VERSION=26.09dev_user, with TRITON_NIGHTLY=1 and TRITON_SBSA=1.

  • Local verification: per-repo pre-commit run --files <changed> passes with no auto-fixes.

  • CI Pipeline ID:

Caveats:

  • Do not merge before the model-repository mount point is rotated: TRITON_SERVER_MODEL_REPO_VERSION derives from TRITON_CONTAINER_VERSION, so 26.09dev must exist on the share first.

Background

Post-release step of the 26.08 train: the default branches move onto the same upstream containers as the just-released r26.08, and pick up the fixes that landed only on the release branch while it stabilised.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: TRI-1691

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the RHEL/manylinux build configuration to use the CPython 3.12.13 installation layout instead of 3.12.1.

  • Updates the Python site-packages source path used to copy PyTorch libraries and headers.
  • Updates the x86_64 library source path to the matching CPython installation.

Confidence Score: 5/5

The PR appears safe to merge, with the two related manylinux paths consistently updated to CPython 3.12.13.

The change is limited to synchronizing the RHEL build’s Python package and x86_64 library source paths, and no reachable build regression or repository-rule violation was identified.

Important Files Changed

Filename Overview
CMakeLists.txt Aligns both hard-coded manylinux CPython paths with version 3.12.13; no actionable defect was established.

Reviews (1): Last reviewed commit: "build: Fix manylinux Python version (#20..." | Re-trigger Greptile

@mc-nv
mc-nv merged commit ef05eac into main Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependencies (build: PRs) cherry-pick Cherry-picked from another branch

Development

Successfully merging this pull request may close these issues.

2 participants