Repository navigation
Conversation
Greptile SummaryThe README now distinguishes the Python support entrypoint from the native LibTorch and PT2 loaders and clarifies that the Python path may load either a Python class or serialized TorchScript artifact.
Confidence Score: 5/5The documentation-only change appears safe to merge. No blocking failure remains; the revised scope now explicitly includes serialized TorchScript models loaded through Important Files Changed
Reviews (2): Last reviewed commit: "docs: fix README scope for Python suppor..." | Re-trigger Greptile |
|
@SiluPanda, thank you for your contribution. Have you signed the Triton CLA? Unfortunately, I'm not see your GitHub handle in our list of CLA signers, and at this time we cannot accept contributions from individuals who have signed a CLA. |
|
@whoisj Thank you for the reminder. I’ve now signed and sent the Triton CLA as an individual contributor for @SiluPanda, with N/A for the corporation fields; I’m not representing LinkedIn or any other corporation for this contribution. Please let me know if anything else is needed. |
Summary
NUM_THREADS,NUM_INTEROP_THREADS, andTORCH_COMPILE_OPTIONAL_PARAMETERSsettings are only used when Triton loads a Python model class frommodel.pyINTER_OP_THREAD_COUNTandINTRA_OP_THREAD_COUNT, which are the CPU-thread parameters handled by the main backend code pathsstableTorchScript threading link with the versioned PyTorch 2.8 page that still contains the actual tuning guidanceRefs triton-inference-server/server#8853.
Why
src/model.pyconsumesNUM_THREADS,NUM_INTEROP_THREADS, andTORCH_COMPILE_OPTIONAL_PARAMETERS, whilesrc/pt/model_state.ccandsrc/pt2/model_state.cchandleINTER_OP_THREAD_COUNT/INTRA_OP_THREAD_COUNTfor serialized TorchScript and PT2 models. The README currently mixes those scopes together and links LibTorch/PT2 thread tuning to astablePyTorch page that now redirects to a TorchScript deprecation stub.Validation
https://docs.pytorch.org/docs/stable/notes/cpu_threading_torchscript_inference.htmlcurrently redirects to a 2.13 stub, whilehttps://docs.pytorch.org/docs/2.8/notes/cpu_threading_torchscript_inference.htmlstill contains the full thread-tuning guidancepre-commit run --files README.md