fix(cli): exit non-zero when workspace rename is rejected - #679
Merged
Merged
Conversation
A rejected rename (same name, invalid name, branch clash) returned
{"success": false} with exit 0. It now fails with an invalid_arguments
error like every other command, and frees the idempotency key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MxqTt1WtVRKkjNXQpgkJS9
Ziinc
commented
Oct 2, 2026
Ziinc
left a comment
Ziinc
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review at ab7cac70: Reviewed rejected-rename error propagation and the surrounding idempotency claim cleanup. No actionable correctness or code-quality issues found in this diff; rejected results now take the standard error path instead of being cached as success.
Validation: static review of the diff, surrounding implementation and tests; PR-head CI reports success. Rust/integration tests were not rerun locally because this environment has no Cargo toolchain.
A rejected `workspace rename` now exits non-zero, so over SSH the rename dialog received an `invalid_arguments: invalid_arguments: ...` error and showed a "Failed to rename workspace" toast on top of the inline message. The rename transport maps that error back to an unsuccessful result with the code stripped, matching a local rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1poGWXMSFcPsJ8V5gujWG
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
treq workspace renamereported a rejected rename (same name, invalid name, branch clash) as{"success": false}and exited 0. That result was also saved under the idempotency key, so a retry replayed itinvalid_argumentserror, so it exits 1 with the standard error body and frees the key🤖 Generated with Claude Code
https://claude.ai/code/session_01MxqTt1WtVRKkjNXQpgkJS9
Generated by Claude Code
Generated by Claude Code