Skip to content

fix/agent-terminal-escaping - #455

Open
Ziinc wants to merge 2 commits into
mainfrom
fix/agent-terminal-escaping
Open

fix/agent-terminal-escaping#455
Ziinc wants to merge 2 commits into
mainfrom
fix/agent-terminal-escaping

Conversation

@Ziinc

@Ziinc Ziinc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Prevent arbitrary agent text and terminal output from leaving the shell in an unterminated quote or subshell state.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Ziinc commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Merged origin/main into this branch (clean merge, no conflicts) and pushed the result.

Regarding the CI failure on .github/workflows/ci.yml run 34613088563 (push event, commit ae936594): it isn't caused by this PR's diff. That run has 0 jobs and conclusion: failure — the same "push"-triggered ci.yml runs on main itself fail identically (e.g. run 34612506698 for a plain main commit, also 0 jobs / failure), because ci.yml's on: block only declares pull_request triggers, so any push-triggered invocation of it fails at startup with no jobs to run. This is a pre-existing, repo-wide artifact unrelated to this branch's changes, so I did not push a fix for it here.

I did verify the actual PR-relevant checks pass locally against the merged branch: prettier --check, eslint, tsc --noEmit, and the unit tests for the changed file (src/hooks/useAgentMessageQueue.test.ts, 10/10 passing) all succeed.

Separately, the check-conventional-title status check is failing because the PR title (fix/agent-terminal-escaping) doesn't match the conventional-commits format the workflow expects (type(scope)?: description) — that's a PR-metadata fix (retitling), not a code fix, so I left it for the PR author/maintainer to address.


Generated by Claude Code

@Ziinc
Ziinc force-pushed the fix/agent-terminal-escaping branch from 457a8b1 to efc4cce Compare September 13, 2026 18:33

Ziinc commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased this branch onto current main (actual rebase, not merge — history rewritten, force-pushed). Both commits (fix: unterminated quote affecting terminal input, chore: formatting) replayed cleanly with no conflicts.

CI on the new head (efc4cce0) still shows the ci.yml workflow failing with 0 jobs run. This is not caused by this PR's diff — it's the repo-wide matrix-context bug (jobs.<job_id>.if referencing matrix.kind, which GitHub Actions doesn't expose at that level), present on main itself and reproducible on every branch/PR right now. It's already being fixed in #484 (fix-ci-matrix-context), which was still in progress as of this rebase. Once #484 merges to main, a rebase/merge of this branch should pick up green CI — no action needed here beyond that.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant