Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chubirka The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Final verification for 51078be:
Merge gate remains contracts#127 → Core#397 canonical re-pin/verification/merge → this consumer canonical Core re-pin/verification. Core#397 documents two unrelated reproduced baseline performance failures and a full-rerun deadline; its current inventory-only volume suite has 9 passing cases. No full-performance-green claim or automatic merge. |
|
/agentic_review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Plan 15, decision 10: the inventory-export reporting slice. Depends on contracts#127 and Core#397:
Changes
portfolio inventory-exportthrough Core's registeredinventory-exportInsight view. Remove the client-side inventory join and copied column definition; Core owns rows, labels, ordering, cached contact resolution and rendering.--format csvas Core-owned CSV stdout with safe one-line/formula-neutralized cells and semicolon-separated lists. No report files are created by the command.--pd-cache-dir, including relative paths, as a per-invocation source override before Core services are wired. Do not place filesystem paths in ViewFilter or REST parameters.{rows: [...]}wrapper and shared Markdown/HTML/CSV via the existingdashboard view inventory-export --out ...materializer. Reject unsupported global/historical inputs, including adapter-only--until,--sla-policyand--invoice, instead of silently dropping them.(created_at DESC, id DESC)ordering, current owners, deduplicated shipping products, recorded product-map precedence and optional product-definition contact semantics.Scope and compatibility
No inventory-declaration storage, owner policy, onboarding, scanner, PQC policy or ranking redesign. One existing leased cloud-audit test now records its synthetic repository's imported default line before submitting the order, as current Core requires. Production authorization/authentication is unchanged; both backends of that fixture passed after the setup correction.
The existing PQC representative-ref fixture also supplied IDs/timestamps that the database
correctly ignores on insert. It now persists its intended test timestamps explicitly and
checks the documented tie-break against actual database-generated UUIDs. This removes a
SQLite clock-resolution flake without changing production PQC selection or policy; both
backends of the corrected scenario passed.
Verification
Merge gate — keep draft
Current review pin is Core
81e27c598e602594ae517aa2e0fc39e49637f962, whose only new contracts dependency is the directly based schema feature in contracts#127. Merge contracts#127, re-pin/verify/merge Core#397 against canonical merged contracts, then re-pin and verify this consumer against merged Core before making it ready. No automatic merges.