postgres/io: pre-allocate buffer capacity and use extend_from_slice i… - #4353
Open
Aditya-9-6 wants to merge 2 commits into
Open
postgres/io: pre-allocate buffer capacity and use extend_from_slice i…#4353Aditya-9-6 wants to merge 2 commits into
Aditya-9-6 wants to merge 2 commits into
Conversation
…n put_length_prefixed Signed-off-by: Aditya <adityadahale96@gmail.com>
Signed-off-by: Aditya <adityadahale96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes
put_length_prefixedinsqlx-postgres/src/io/buf_mut.rs.Rationale & Performance Benefit
Nearly all Postgres wire protocol messages sent to the database are length-prefixed.
put_length_prefixedreserves the 4-byte length header at the beginning of each message.Currently, it calls
self.extend(&[0; 4]), which iterates over array elements and may trigger intermediate re-allocations if capacity is tight.Optimizations made:
self.reserve(4).self.extend_from_slice(&[0; 4])slice copy instead of array iterator extension.