feat: render Markdown and safe links in messages - #142
Merged
Conversation
Contributor
Greptile SummaryThis PR adds authenticated LXMF Markdown rendering and validated message links while preserving plaintext fallback for unsupported renderer values.
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code failure identified. Renderer metadata is preserved across live and stored messages, unsupported values remain plaintext, validated link targets follow reachable handlers, and linked NomadNet paths flow into the browser’s initial fetch. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Received or persisted LXMF message] --> B{Renderer field 0x0F<br/>is exact integer 0x02?}
B -- No --> C[Render plaintext]
B -- Yes --> D[Render Markdown]
C --> E[Detect validated links]
D --> F[Intercept Markdown links]
E --> G{Link target}
F --> G
G -- HTTP or HTTPS --> H[System browser]
G -- LXMA --> I[Registered app deep link]
G -- NomadNet --> J[In-app NomadNet browser]
J --> K[Fetch requested initial path]
Reviews (1): Last reviewed commit: "fix: escape interpolation in code fixtur..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x0Fcontains the exact integer renderer value0x02Verification
swift test --filter MessageRendererTests- 2 passedColumbaAppTestson iPhone 17 simulator - 197 passedColumbaModelBAppTestscompatibility suite - 21 passedRisk and rollback
The behavior is receive-only and fails closed to plaintext. Removing the new package products and
MessageBodyintegration restores the previous plaintext-only presentation.Fixes #136
Fixes #141