fix: stabilize the iOS conversation timeline - #140
Merged
Conversation
Contributor
Greptile SummaryThe PR replaces the iOS SwiftUI conversation stack with a UIKit collection-view timeline and strengthens pagination, viewport continuity, and outbound-message persistence.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported unsafe reply-target path now validates target safety at admission and serializes the canonical wire hash when sending. Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as MessageTimelineView
participant VM as MessagingViewModel
participant Repo as MessageRepository
participant Backend as LXMF Backend
UI->>VM: Load or paginate messages
VM->>Repo: Fetch records using record cursor
Repo-->>VM: Persisted message page
VM-->>UI: Reconciled visible messages
UI->>VM: Send message
VM->>UI: Add optimistic unsafe row
VM->>Backend: Submit LXMF message
Backend-->>VM: Canonical wire hash
VM->>Repo: Persist or recover identity transition
Repo-->>VM: Durable canonical or uncertain row
VM-->>UI: Refresh timeline and targeting state
Reviews (2): Last reviewed commit: "fix: gate timeline replies by target saf..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UICollectionViewembedded throughUIViewControllerRepresentableUIHostingConfiguration, including adjustable message text sizingWhy
On physical iPhone hardware, the lazy SwiftUI timeline could discard every realized row during navigation, keyboard changes, typing, and repository updates while the message model remained populated. It could also fail to trigger or retain older-history pagination. The collection view gives the timeline one explicit owner for cell reuse, pagination, viewport continuity, and keyboard-driven viewport changes.
Verification
No user data was wiped during device verification.