Add adjustable conversation message text size - #139
Merged
Conversation
Contributor
Greptile SummaryAdds a persistent, migration-compatible conversation message-body text scale and a native SwiftUI picker, while leaving secondary message metadata unscaled.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The preference is normalized at every persistence boundary, loaded into conversation state, restricted to primary message-body rendering, included symmetrically in migration export and import, and compiled into both app targets. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
User[Conversation menu] --> Picker[Text size picker]
Picker -->|OK| Settings[SettingsRepository]
Settings --> Defaults[App Group UserDefaults]
Settings --> ViewState[MessagingView scale state]
ViewState --> Bubble[MessageBubble primary body]
Settings --> Exporter[MigrationExporter]
Importer[MigrationImporter] --> Settings
Reviews (1): Last reviewed commit: "test: calibrate picker rendering bounds" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #135
Verification
git diff --checkpassedVisual verification
Verified normal and accessibility-width picker renderings plus long-message and reply-bubble renderings at 70%, 100%, and 200%. No clipping or unintended secondary-text scaling was observed.
Risk and rollback
The new preference defaults to 100%, so existing rendering is unchanged until the user selects another value. Removing this PR restores prior behavior; migrated backups without the preference retain the default.