fix(ios): retain native ABI in TestFlight archives - #132
Merged
Conversation
Contributor
Greptile SummaryThe PR preserves the complete embedded-Python C ABI in post-processed Release artifacts and verifies the resulting Mach-O in CI.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported target-scope issue is addressed by deleting the native archive settings from all Model B configurations and assigning them only to shipping Release, with stale-input and idempotency coverage. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Manifest["Native export manifest"] --> ShippingRelease["ColumbaApp Release"]
ShippingRelease --> PostProcess["Archive post-processing"]
PostProcess --> Verify["Mach-O export verification"]
Reconciler["Target reconciler"] --> ShippingRelease
Reconciler --> ModelB["ColumbaModelBApp"]
ModelB --> Isolated["Export and strip settings removed"]
Reviews (7): Last reviewed commit: "test(ios): tolerate native tab identifie..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@_cdeclentry point in archived Release executablesRoot cause
A normal Release build retained the native C ABI, but Xcode's Archive post-processing stripped it. Native CoreBluetooth therefore continued to populate the BLE UI while embedded Python could not resolve
columba_ble_start,columba_ble_connect, orcolumba_ble_sendthroughctypes.CDLL(None). The Reticulum interface stayed offline and could not exchange announces.Verification
0/14BLE ABI symbols29/29Python-facing native ABI symbols29/29exports54/54201/201Risk and rollback
The Release executable keeps only the explicitly listed global entry points through archive stripping. The static contract requires the export manifest to exactly match every Swift
@_cdecl, and the artifact checker validates exact defined symbols after post-processing. Rollback is the two commits in this PR, but that would restore the TestFlight failure.