-
Notifications
You must be signed in to change notification settings - Fork 22
Unifying DeFi errors to a common format #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
48c6704
fix(appkit): rework connectors events
heyllog eafb87b
feat(appkit): delete BalanceBadge
heyllog 476b166
feat(appkit): fix send decimals error
heyllog 7437ad4
feat: unified API for providers errors
heyllog 3b5ead5
Merge branch feat/TON-622-crypto-onramp-design into feat/codegen-feat…
heyllog 2a8a7ea
feat(crypto-onramp): error handling
heyllog ae88ab5
feat(crypto-onramp): delete duplicates
heyllog b077ce2
feat(crypto-onramp): delete try/catches
heyllog 663fb48
feat(crypto-onramp): make defi errors more typesafe
heyllog 87e15f0
feat(crypto-onramp): delete createError
heyllog c3ec2c3
merge main
heyllog 7c6aeaa
merge main
heyllog 3c7f464
feat(defi): errors in defi managers
heyllog 36622da
feat(defi): changeset
heyllog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@ton/walletkit': patch | ||
| '@ton/appkit': patch | ||
| '@ton/appkit-react': patch | ||
| --- | ||
|
|
||
| DeFi operations (swap, staking, crypto-onramp, gasless) now always throw a typed `DefiError` on failure — a specific subclass (`SwapError`, `StakingError`, `CryptoOnrampError`, `GaslessError`) when available, otherwise a `DefiError` with the new `DefiErrorCode.Unknown` code (the original error is preserved in `details`). Failures can be reliably caught and branched on by `code`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert the specific
ProviderNotFoundbehavior, not just the error class.Line [117] only checks
DefiError, which can hide regressions in error-code semantics for this path.Suggested test tightening
As per coding guidelines, "Test behaviors, not implementation details. Always update existing tests related to your changes."
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines