chore: Switch to an async version of DownloadManager#353
Open
blainekasten wants to merge 1 commit intonextfrom
Open
chore: Switch to an async version of DownloadManager#353blainekasten wants to merge 1 commit intonextfrom
blainekasten wants to merge 1 commit intonextfrom
Conversation
blainekasten
force-pushed
the
blaine/eng-87128-switch-downloadmanager-to-use-async-together
branch
from
3011341 to
a785c6a
Compare
zainhas
approved these changes
May 2, 2026
| raise APIStatusError( | ||
| "Error downloading file", | ||
| response=e.response, | ||
| body=e.response, |
Collaborator
There was a problem hiding this comment.
Suggested change
| body=e.response, | |
| body=e.body, |
| raise APIStatusError( | ||
| "Error downloading file", | ||
| response=e.response, | ||
| body=e.response, |
Collaborator
There was a problem hiding this comment.
Suggested change
| body=e.response, | |
| body=e.body, |
| raise APIStatusError( | ||
| "Error downloading file", | ||
| response=e.response, | ||
| body=e.response, |
Collaborator
There was a problem hiding this comment.
Suggested change
| body=e.body, |
| raise APIStatusError( | ||
| "Error downloading file", | ||
| response=e.response, | ||
| body=e.response, |
Collaborator
There was a problem hiding this comment.
Suggested change
| body=e.body, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes an AsyncDownloader so we can use async code in CLI and not wrap with a new client.