bump qemu to 11.0.1:#185
Merged
Merged
Conversation
Upgrading Alpine surfaced an issue with the bundled qemu-img 6.1.0 crashing with SIGSEGV inside libcurl's connection-pool teardown when built against libcurl >= 8.10, which is what every currently-supported Alpine release ships. The crash happens after the convert succeeds, so the destination disk is left in an indeterminate state and the action reports failure on every run. Newer qemu reworked block/curl.c to cope with libcurl's multi-event API and is no longer affected. While here, also fix HTTPS sources (static libcurl looks for /etc/ssl/cert.pem, which scratch images don't have) and surface convert progress so long downloads aren't silent. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
added
kind/bug
There was a problem hiding this comment.
Pull request overview
Upgrades the qemuimg2disk action’s bundled qemu-img to a newer QEMU release to avoid crashes seen with newer libcurl versions on currently-supported Alpine, while also improving HTTPS CA-bundle handling in the scratch image and making conversions less “silent” via progress output.
Changes:
- Bump bundled QEMU/qemu-img from
6.1.0to11.0.1and adjust build deps accordingly. - Ensure HTTPS downloads work in the scratch image by providing a CA bundle at
/etc/ssl/cert.pem. - Add
qemu-img convertprogress output and add a local reproduction helper script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| qemuimg2disk/Dockerfile | Updates QEMU version/build dependencies and adds CA-bundle copy to support HTTPS in scratch image. |
| qemuimg2disk/entrypoint.sh | Enables qemu-img convert progress output (-p). |
| qemuimg2disk/test-local.sh | Adds a local helper script to reproduce/action-test using a loop device-backed “host_device” target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge Queue Status
This pull request spent 5 minutes 27 seconds in the queue, including 4 minutes 7 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrading Alpine surfaced an issue with
the bundled qemu-img 6.1.0 crashing with SIGSEGV inside libcurl's connection-pool teardown when built against libcurl >= 8.10, which is what every currently-supported Alpine release ships. The crash happens after the convert succeeds, so the destination disk is left in an indeterminate state and the action reports failure on every run.
Newer qemu reworked block/curl.c to cope with libcurl's multi-event API and is no longer affected. While here, also fix HTTPS sources (static libcurl looks for /etc/ssl/cert.pem, which scratch images don't have) and surface convert progress so long downloads aren't silent.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: