DOCS-2997: Correct two statements in the Network reference - #2972
Merged
ctauchen merged 1 commit intoAug 27, 2026
Conversation
The bridge MAC address has to be set explicitly, but it does not have to differ from the trunk's. The trunk's address is a reasonable choice, and avoiding it does not help on the one driver where reusing it appears to fail; that fault has its own guidance in the bridge preparation guide. Say where the reserved gateway address comes from. Calico takes it from a route's nextHop, so a subnet declared without routes has no reserved gateway and the address can be assigned to a workload.
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Calico Enterprise Network resource reference (l2Bridge section) to reflect corrected guidance from prior review feedback, improving accuracy around subnet gateway reservation and existing bridge MAC address requirements.
Changes:
- Clarifies how a subnet’s reserved gateway address is determined (derived from
routes[].action.nextHop). - Updates the “existing bridge” requirements to remove the “must not be the trunk’s” MAC guidance and emphasize MAC stability instead.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | routes | Additional routes to program into the workload's routing table for this interface, beyond the connected route for the subnet. | | List of [L2Route](#l2route) | | ||
|
|
||
| $[prodname] does not assign the network address, the broadcast address, or the gateway address of a subnet. | ||
| The gateway address is the `nextHop` of a route declared on that subnet, so a subnet with no routes has no reserved gateway address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to the l2Bridge section of the Network reference, both from Shaun's review of the L2 bridge documentation. The page they belong to merged in #2950 before the review comments landed, so they come as a follow-up.
The bridge MAC address requirement no longer says the address must differ from the trunk's. Shaun withdrew that guidance during review: the trunk's address is a reasonable choice on a working driver, and avoiding it does not help on the one driver where reusing it appears to fail. That fault is specific to Intel ice NICs and now has its own guidance in the bridge preparation guide, in #2946. The requirement that the address be set explicitly is unchanged, and so is the reason for it.
The subnet section now says where the reserved gateway address comes from. Calico takes it from the nextHop of a route declared on that subnet, so a subnet declared without routes has no reserved gateway and the address can be assigned to a workload. That was not deducible from the reference as written, and it matters because the setup guide previously showed subnets with no routes at all.
Reviewers: https://deploy-preview-2972--calico-docs-preview-next.netlify.app/calico-enterprise/next/reference/resources/network