Remove stale v1/v2 directory branching and promote v2 as default#2
Open
brionmario wants to merge 1 commit into
Open
Remove stale v1/v2 directory branching and promote v2 as default#2brionmario wants to merge 1 commit into
brionmario wants to merge 1 commit into
Conversation
brionmario
force-pushed
the
migrate
branch
2 times, most recently
from
76158cf to
d96d212
Compare
|
Important Review skippedToo many files! This PR contains 178 files, which is 28 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (178)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Removes the legacy v1/v2 platform-dispatch layer from the JavaScript SDKs. v1 targeted the WSO2 Identity Server embedded flow (
/api/server/v1/flow/execute) and is no longer needed — ThunderID is now the only supported platform. v2 (ThunderID native flow,/flow/execute) becomes the unconditional default, and allV2-suffixed exports are renamed to their clean equivalents.🔧 Summary of Breaking Changes
Platformenum andidentifyPlatformdeleted. Runtime platform-detection (if (platform === Platform.ThunderID)) is removed entirely.V2-suffixed exports renamed. e.g.EmbeddedFlowComponentTypeV2→EmbeddedFlowComponentType,executeEmbeddedSignInFlowV2→executeEmbeddedSignInFlow,useOAuthCallbackV2→useOAuthCallback.EmbeddedFlowExecuteRequestPayload,EmbeddedFlowExecuteResponse,EmbeddedFlowStatus,EmbeddedSignInFlowHandleRequestPayloadare no longer exported.platformprop removed fromThunderIDContextandThunderIDProviderProps(React + Vue).inheritFromBranding/modeprops removed from ReactThemeProvider.💥 Impact
Any consumer that:
*V2-suffixed name — compile error; rename to the clean equivalentplatformtoThunderIDProvider/useThunderID— prop silently ignored → remove itPlatform,identifyPlatform, or the deleted v1 types — compile error; no replacementinheritFromBrandingormodeto ReactThemeProvider— compile error; remove those props🔄 Migration Guide
Rename V2-suffixed imports:
Remove
platformfrom provider config:Remove deleted v1 types — use the v2 equivalent:
Approach
Every package carried a dispatcher pattern — a top-level component or function that checked
platform === Platform.ThunderIDat runtime and routed to av1/orv2/subdirectory. With only one platform remaining the entire dispatch layer is dead code.Dispatcher removal: All dispatcher files (e.g.
SignIn.tsx,BaseSignIn.tsx,ThemeProvider.tsx) were replaced with thin re-exports pointing directly at thev2/implementation. Thev1/directories were deleted.Name promotion: V2-suffixed identifiers were renamed in-place across every package that referenced them — imports, type annotations, enum usages, and dependency arrays — so the public API is clean with no aliases.
Platform plumbing removal:
Platformenum,identifyPlatformutility, and theplatformfield onThunderIDContextwere deleted.FlowMetaProvider(React) previously gated fetches behindplatform === Platform.ThunderID; that guard was simplified to theenabledflag alone.No runtime behaviour changes for ThunderID consumers — the v2 code path was already the active one.
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks