Fix KtLint issues & other CI related issues#2
Open
brionmario wants to merge 1 commit into
Open
Conversation
486ba1d to
92a7ddd
Compare
ad5a15f to
2608ea1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes KtLint formatting violations and unblocks CI. Also adds missing Gradle wrapper files and corrects composite build configuration in the quickstart sample so it resolves dependencies and builds independently.
Approach
.editorconfigwithktlint_function_naming_ignore_when_annotated_with = Composableto suppress false-positive KtLint failures on@Composablefunctions.gradlew,gradlew.bat,gradle/wrapper/).samples/quickstart/settings.gradle.ktsto includedependencyResolutionManagementwithgoogle()andmavenCentral()— composite build dependency repos don't propagate from included builds to the consumer project.samples/quickstart/gradle.propertieswithandroid.useAndroidX=true— the SDK root'sgradle.propertiesis not inherited by the quickstart composite build.samples/quickstart'spluginManagement.pluginsblock — thecom.android.libraryversion in the composite build doesn't propagate tocom.android.applicationin the consumer project.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks