Skip to content

Fix KtLint issues & other CI related issues#2

Open
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:android-sdk
Open

Fix KtLint issues & other CI related issues#2
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:android-sdk

Conversation

@brionmario

@brionmario brionmario commented Jun 18, 2026

Copy link
Copy Markdown
Member

Purpose

Fixes KtLint formatting violations and unblocks CI. Also adds missing Gradle wrapper files and corrects composite build configuration in the quickstart sample so it resolves dependencies and builds independently.

Approach

  • Added .editorconfig with ktlint_function_naming_ignore_when_annotated_with = Composable to suppress false-positive KtLint failures on @Composable functions.
  • Added root-level Gradle wrapper (gradlew, gradlew.bat, gradle/wrapper/).
  • Fixed samples/quickstart/settings.gradle.kts to include dependencyResolutionManagement with google() and mavenCentral() — composite build dependency repos don't propagate from included builds to the consumer project.
  • Added samples/quickstart/gradle.properties with android.useAndroidX=true — the SDK root's gradle.properties is not inherited by the quickstart composite build.
  • Declared AGP and Kotlin plugin versions explicitly in samples/quickstart's pluginManagement.plugins block — the com.android.library version in the composite build doesn't propagate to com.android.application in the consumer project.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@brionmario brionmario force-pushed the android-sdk branch 4 times, most recently from 486ba1d to 92a7ddd Compare June 18, 2026 20:55
@brionmario brionmario changed the title Refactor error handling to use ThunderIDErrorCode and update related … Fix KtLint issues & other CI related issues Jun 19, 2026
@brionmario brionmario force-pushed the android-sdk branch 5 times, most recently from ad5a15f to 2608ea1 Compare June 19, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant