[pull] master from google:master#175
Merged
Merged
Conversation
Change email for @cary-ilm to seabeepea@gmail.com. I'll be losing access to cary@ilm.com at the end of July. Signed-off-by: Cary Phillips <cary@ilm.com>
…rd_party from analysis (#15860) **What**: Restores the Fuzz Introspector build for connectedhomeip, which has failed every day since 2024-12-17 with `context deadline exceeded` (#13153). **Root cause**: `base-builder/compile` runs the introspector source analysis before `build.sh`. On connectedhomeip it runs ~11h and times out — ~4.3h in the initial whole-tree tree-sitter load (dominated by files vendored under `third_party`) plus ~6h across 239 "harnesses", ~230 of which are fuzzers vendored by dependencies (mbedtls, openthread, libdatachannel's bundled copy of LLVM's Fuzzer test suite, boringssl, ...) rather than connectedhomeip's own ~10 targets. **Fix**: Because the analysis runs before `build.sh`, `third_party` is moved out of the source tree in the `Dockerfile` (after `bootstrap.sh`, which needs `third_party/pigweed`) and restored in `build.sh` before `gn gen`. The real asan/msan/coverage builds are unaffected — they compile with `third_party` restored; only the pre-build introspector analysis sees the reduced tree. The dead `all-clusters-minimal-app` fuzzing driver (compiled by no target) is also dropped. **Effect**: The introspector report becomes scoped to connectedhomeip's own code rather than descending into vendored dependency internals — the useful scope here, and a report where there has been none for ~7 months. **Testing**: Verified locally that (1) with `third_party` excluded the analysis clears the tree-sitter load in seconds (was ~4.3h) and processes connectedhomeip's own harnesses through to report generation, and (2) `build_fuzzers --sanitizer address` still compiles all targets with `third_party` restored by `build.sh`. The exact introspector wall-clock will be confirmed by the periodic cloud build. Fixes #13153
Objects should be freed as often as they are created. This change was discussed with and approved by Derek B. Noonburg from the Xpdf project.
Fixing a few Envoy project build issues, and cleaning up some old tech-debt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )