[pull] master from apify:master#242
Merged
Merged
Conversation
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://redirect.github.com/actions/setup-node) | action | major | `v6` → `v7` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v7.0.0`](https://redirect.github.com/actions/setup-node/compare/v6.5.0...v7.0.0) [Compare Source](https://redirect.github.com/actions/setup-node/compare/v7.0.0...v7.0.0) ### [`v7`](https://redirect.github.com/actions/setup-node/compare/v6.5.0...v7.0.0) [Compare Source](https://redirect.github.com/actions/setup-node/compare/v6.5.0...v7.0.0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "every weekday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apify/crawlee). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTkuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI1OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
`mergeCookies()` splits each source cookie string on `; ` and forced the result of `Cookie.parse()` with a non-null assertion. We now check this and throw on invalid cookies. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
The scheduled E2E runs have been red since 2 July. Two independent causes. ## The token Every failure was `ApifyApiError: User was not found or authentication token is not valid` (401), which looks like an expired secret but is not — the login succeeds every run. The harness read the token out of `~/.apify/auth.json`. Since [apify-cli#1197](apify/apify-cli#1197) the bundle distribution (what CI installs) stores the token in the OS keyring and strips it from that file — intended behaviour, as plaintext storage was the bug it fixed. The file still exists, so the `existsSync` guard passed, `getApifyToken()` returned `undefined`, and `process.env.APIFY_TOKEN ??= undefined` coerced it to the literal string `"undefined"`. That bogus token is what the API rejected. It landed within the `1.6.3` beta line (`beta.6` wrote `auth.json`, `beta.25` wrote the keyring), which is why it broke ~2 weeks before 1.7.0 shipped. - Pass `APIFY_TOKEN` from the existing secret, so the harness no longer reaches into the CLI's credential store. The beta CLI is still installed and exercised as before. - Throw a clear error when `auth.json` has no token, instead of silently yielding `"undefined"`. ## The demo store With the token fixed, PLATFORM actually ran its tests for the first time since 2 July — and `cheerio-robots-file` then failed on `429`s from `warehouse-theme-metal.myshopify.com`. The robots.txt behaviour under test was fine; the crawl never got off the ground, so `requestsFinished` was 0 and the precondition failed. The store rate-limits plain-HTTP clients from the platform's shared egress IP. The browser-driven tests on the same IP get through. The six tests crawling that store now go through `Actor.createProxyConfiguration()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )