[pull] master from kevoreilly:master#501
Merged
Merged
Conversation
calc_scoring() decided Undetected vs Failed based solely on the presence of behavior.processtree. Static analysis (category "static") never runs the sample in a VM, so processtree is always empty by design — every clean static analysis was wrongly reported as "Failed". Also check raw YARA matches on the target file (not just family-attributed detections) to surface static hits as "Suspicious" instead of silently discarding them.
- finalMalscore now set to 4.0 when a raw YARA hit marks a static
analysis as Suspicious, matching the 4.0-6.0 convention used by the
existing Suspicious-Unknown branch instead of leaving it at 0.
- Replace chained .get(key, {}) calls with `... or {}` fallbacks so an
explicit None on an intermediate key (target/file) can't raise
AttributeError, and avoid the redundant double lookup of "target".
Addresses gemini-code-assist review on PR #3102.
…d-status Fix false "Failed" status for static analysis with no signature hit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )