Skip to content

feat(eslint-plugin-rules): update eslint-plugin-rules for PF5 - #486

Closed
lfu wants to merge 1 commit into
theforeman:masterfrom
lfu:pf5_require_ouiaid
Closed

lfu wants to merge 1 commit into
theforeman:masterfrom
lfu:pf5_require_ouiaid

Conversation

@lfu

@lfu lfu commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Update eslint-plugin-rules for patternfly 5.

To test

# Copy the updated rule to Foreman's node_modules
cp /home/vagrant/foreman-js/packages/eslint-plugin-rules/lib/require-ouiaid.js \
   /home/vagrant/foreman/node_modules/@theforeman/eslint-plugin-rules/lib/require-ouiaid.js

Then run:

cd /home/vagrant/foreman
npx eslint --no-eslintrc --no-inline-config \
  --plugin @theforeman/rules \
  --rule '@theforeman/rules/require-ouiaid: error' \
  --parser babel-eslint \
  ../foreman_rh_cloud/webpack/

That tests the default list.
To test the additional option, create a minimal config file:

cat > /tmp/ouiaid-test.json << 'EOF'
{
  "parser": "babel-eslint",
  "plugins": ["@theforeman/rules"],
  "rules": {
    "@theforeman/rules/require-ouiaid": ["error", { "additional": ["MyExtraComponent"] }]
  }
}
EOF

cd /home/vagrant/foreman
npx eslint --no-eslintrc --no-inline-config \
  -c /tmp/ouiaid-test.json \
  ../foreman_rh_cloud/webpack/

@MariaAga

Copy link
Copy Markdown
Member

@lfu foreman-js is no longer use, please contribute to foreman (if needed)

@ogajduse

Copy link
Copy Markdown
Member

@lfu foreman-js is no longer use, please contribute to foreman (if needed)

Should we archive this project then?

@MariaAga

Copy link
Copy Markdown
Member

@ogajduse Should we do it before we finish removing all the imports, or after?

@lfu
lfu force-pushed the pf5_require_ouiaid branch from ee390b2 to d3ae553 Compare July 28, 2026 14:08
@ogajduse

Copy link
Copy Markdown
Member

@ogajduse Should we do it before we finish removing all the imports, or after?

Oh, I did not know that we have an ongoing thing here. Then I'd say let's archive when we're done with the import removal.
Is there any place where I can see the progress of the removal?

@MariaAga

Copy link
Copy Markdown
Member

@ogajduse https://redhat.atlassian.net/browse/SAT-26301

@lfu

lfu commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

In favor of theforeman/foreman#11117

@lfu lfu closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants