fix: deny-all permission and discover goroutine recovery#42
Merged
Conversation
1. calculatePermissions: a deny permission with empty resource, empty expression, AND empty actions means 'deny every action on every resource'. The old code built an empty (non-nil) action map that never matched, so GetAllGrantedPermissions wrongly reported permissions the user did not have. Now it returns no permissions, matching IsAllowed's matchResourceAction semantics. Added a test case. 2. etcd discover SaveDiscoverRequest: the fire-and-forget DeleteRequests cleanup goroutine had no panic recovery; a panic (e.g. nil client during shutdown) would crash the process. Added defer/recover. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code