fix: channel-safety in StopWatch and signal handling#41
Merged
Conversation
Three related send-on-closed-channel hazards: 1. file/etcd StopWatch sent on s.stop while the watch goroutine's defer closed it. On the panic-recovery exit path the channel could be closed before StopWatch ran, making the send panic. Now StopWatch closes s.stop (idempotent via stopOnce) and the goroutine defers no longer close it. For etcd this also wakes ALL inner watch goroutines (a single send only woke one, leaking the rest after a watch restart). 2. cmd main.go closed intChan after the first signal while signal.Notify was still registered; a second SIGINT/SIGTERM would panic. Replaced with signal.Stop(intChan). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code