Add start_delay for SAA#1491
Merged
Sushisource merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
mjameswh
approved these changes
Apr 29, 2026
cconstable
approved these changes
Apr 29, 2026
cconstable
reviewed
Apr 29, 2026
|
|
||
| activity_id = str(uuid.uuid4()) | ||
| task_queue = str(uuid.uuid4()) | ||
| start_delay = timedelta(seconds=3) |
Contributor
There was a problem hiding this comment.
Is negative duration considered an error?
Contributor
There was a problem hiding this comment.
if it is and it's handled client-side, is it worth testing?
Member
Author
There was a problem hiding this comment.
Probably, I believe server will reject it though. Fair point though, we can include a nice client side error for negative values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
See title
Why?
Supports new feature
Checklist
Closes
How was this tested:
Added interceptor based test. CLI doesn't have new enough server to do an e2e test, but, this is sufficient.
Any docs updates needed?