[sync] T5102 Emit per-record clear ops on select option removal#3347
[sync] T5102 Emit per-record clear ops on select option removal#3347tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@7cb99ff Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 258986a712
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @Optional() | ||
| @Inject(SpaceDataDbMigrationGuardService) | ||
| private readonly spaceDataDbMigrationGuard?: SpaceDataDbMigrationGuardService |
There was a problem hiding this comment.
When BaseService is constructed by BaseModule, this optional dependency is not provided: BaseModule does not import SpaceModule, and SpaceModule is the only module that registers/exports SpaceDataDbMigrationGuardService. Because the new assert*Writable helpers use optional chaining, base create/delete/duplicate operations during an active data-DB migration silently skip the freeze guard, allowing source data to change while copy/validation is running. Move the guard into a shared/imported module (or make it required where these guards are used) so these write paths are actually blocked.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
112 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@7cb99ff
This PR was automatically created by the sync workflow.