Move TryFrom<&FnDecl> for FunctionType from types.rs to conversions.rs#12
Open
Meredith2328 wants to merge 1 commit into
Open
Conversation
src/ir/types.rs, the module that defines IR data structures, previously imported crate::ast solely to implement TryFrom<&ast::FnDecl> for FunctionType. This introduced a reverse dependency — the low-level IR type-definition layer had to know about AST nodes — and scattered the AST→IR conversion logic across two files. Unify all AST→IR type and signature conversions under src/ir/gen/conversions.rs. - Remove use crate::ast from types.rs - Move the TryFrom<&FnDecl> impl from types.rs to conversions.rs (no logic changed — the conversion and its validation rules are preserved verbatim) - Add FunctionType import to conversions.rs - Update module-level and section comments in conversions.rs to reflect the broader scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/ir/types.rs, the module that defines IR data structures, previously imported crate::ast solely to implement
TryFrom<&ast::FnDecl>forFunctionType.This introduced a reverse dependency — the low-level IR type-definition layer had to know about AST nodes — and scattered the AST→IR conversion logic across two files.
This commit unifies all AST→IR type and signature conversions under src/ir/gen/conversions.rs by moving the only such impl that previously lived outside that module.
crate::astfrom types.rsTryFrom<&FnDecl>impl from types.rs to conversions.rs (no logic changed — the conversion and its validation rules are preserved verbatim)FunctionTypeimport to conversions.rs