Skip to content

feat(docs): clarify rounding, division operations and update descriptions#3320

Open
geooner wants to merge 9 commits into
tact-lang:mainfrom
geooner:docs/clarify-rounding-desc
Open

feat(docs): clarify rounding, division operations and update descriptions#3320
geooner wants to merge 9 commits into
tact-lang:mainfrom
geooner:docs/clarify-rounding-desc

Conversation

@geooner

@geooner geooner commented May 30, 2025

Copy link
Copy Markdown

…eiling and floor division in math documentation
@geooner

geooner commented May 31, 2025

Copy link
Copy Markdown
Author

Hi @novusnota @Gusarich the ci test passed. I think this is good to go, but still please review it, thanks.

@geooner

geooner commented Jun 4, 2025

Copy link
Copy Markdown
Author

Hello, @pyAndr3w @novusnota its been a while, do you guys have any updates on this?

@novusnota

novusnota commented Jun 4, 2025

Copy link
Copy Markdown
Member

Hello, novusnota its been a while, do you guys have any updates on this?

Hi and sorry — I've been working on other things, but I'll happily review your PR a bit later today-tomorrow :)

@novusnota novusnota left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've left suggested changes to apply, and if or once you agree, we'll proceed to merge them

Comment thread docs/src/content/docs/ref/core-math.mdx Outdated
Comment thread docs/src/content/docs/ref/core-math.mdx Outdated
Comment thread docs/src/content/docs/ref/core-math.mdx Outdated
Comment thread docs/src/content/docs/ref/core-math.mdx Outdated
Comment thread docs/src/content/docs/ref/core-math.mdx Outdated
Comment thread docs/src/content/docs/book/operators.mdx Outdated
Comment thread docs/src/content/docs/book/operators.mdx Outdated
geooner and others added 2 commits June 5, 2025 06:44
Apply suggestions from code review

Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@geooner

geooner commented Jun 5, 2025

Copy link
Copy Markdown
Author

@novusnota have a look now, I've applied your suggestions. I think this is ready to be merged now.

@novusnota novusnota changed the title Feat(docs): Clarify rounding, division operations and update descriptions feat(docs): clarify rounding, division operations and update descriptions Jun 5, 2025

@novusnota novusnota left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@geooner

geooner commented Jun 18, 2025

Copy link
Copy Markdown
Author

@novusnota hi, sorry to ping you again, but this has been open for a while now, could you please merge this?

@geooner

geooner commented Jun 18, 2025

Copy link
Copy Markdown
Author

@novusnota the ci passed

@novusnota

Copy link
Copy Markdown
Member

@novusnota hi, sorry to ping you again, but this has been open for a while now, could you please merge this?

@geooner I myself cannot merge this, but I've pinged the folks who can. Let's wait a bit to see their response 🙏

@novusnota novusnota requested a review from anton-trunov June 19, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct and clarify rounding mode descriptions in docs

2 participants