feat: calculator v61 redesign & os widget#942
Conversation
48aa6fa to
2183e5d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2183e5d8b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2183e5d to
5178b8d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5178b8d985
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5178b8d to
635084f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 635084fb43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
635084f to
286c5d5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 286c5d5b56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
286c5d5 to
4d16994
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d169946b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fix: simplify scan button highlight fix: keep tab bar fully opaque fix: keep tab bar opaque on exit fix: sync calculator tab bar transition fix: align fiat placeholder text fix: place cursor before placeholder fix: shrink calculator widget preview rows fix: show fiat decimal placeholder chore: fix naming agent rules fix: match calculator cursor style fix: show calculator input cursor fix: animate tab bar visibility refactor: apply naming agent rules refactor: isolate calculator numpad state fix: open app from calculator widget fix: flash calculator numpad errors refactor: extract private calculator numpad chore: update detekt command in docs fix: calculator numberpad bottom see-through refactor: extract MoneyType model fix: highlight calculator input bg instead of border fix: animate calculator pad collapse fix: remove calculator pad divider fix: center calculator os widget fix: refine calculator gestures fix: polish calculator input fix: dismiss calculator on outside tap fix: open calculator from os widget fix: align calculator preview color fix: group calculator fiat display fix: lock calculator widget scroll fix: hide tab bar during calculator input fix: normalize calculator fiat input fix: avoid grouped calculator fiat fix: use calculator number pad fix: show calculator widget preview fix: handle calculator keyboard fix: use calculator input masks
4d16994 to
85fcf98
Compare
Fixes #937
Refreshes the Bitcoin Calculator widget for the v6.1 widget design and brings it into the Android OS widget system, refactored to route its ui logic to the viewmodel and improve formatting with locale thousands and decimal separator support for fiat input.
Description
Design refs:
Preview
calc_os.mp4
calc_app.mp4
QA Notes
Manual Tests
Dev verified locally:
Reviewer / QA requested:
Automated Tests
Added in this PR:
CalculatorViewModelTest: covers stored value hydration, legacy value backfill, BTC input sanitization/conversion/persistence, fiat input sanitization/conversion/persistence, fiat conversion storage without grouping, currency refresh, and display-unit changes.CalculatorCardStateTest: covers calculator formatting helpers, money separators, fiat placeholder zero behavior, hydration guards, and number-pad input/delete behavior.Integration (Android tests) added via stacked PRs:
Automated Checks
./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detekt