Fix Bugcrowd scope extraction#94
Open
Parasimpaticki wants to merge 1 commit into
Open
Conversation
BugCrowd extraction was broken because their engagement page format changed: the data-api-endpoints attribute is now rendered on several elements and the first one (navbar) lacks the brief endpoint key. Select the element that actually contains engagementBriefApi.getBriefVersionDocument instead. Tested with two different accounts via their session tokens.
Owner
|
Thanks! Will review ASAP |
Owner
|
Hey @Parasimpaticki, i've checked this code and i'm gettng the same exact number of entries running it on bugcrowd. Is this the case for you as well? Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BugCrowd scope extraction was broken because their engagement page format changed.
The
data-api-endpointsattribute is now rendered on several elements (navbar, footer, toasts, session timer, ...). The previous code grabbed theResearcherEngagementBriefelement, but the change in layout meant the first matched element no longer reliably carriedengagementBriefApi.getBriefVersionDocument.This PR selects the element that actually contains
engagementBriefApi.getBriefVersionDocument(preferringResearcherEngagementBrief, then falling back to a scan of alldata-api-endpointselements).Tested with two different accounts by providing their session tokens, scope now extracts correctly.