Repository navigation
Merged
Conversation
askoufis
commented
Mar 26, 2026
| name: 'preset-default', | ||
| params: { | ||
| overrides: { | ||
| removeTitle: false, |
Contributor
Author
There was a problem hiding this comment.
removeTitle is now disabled by default.
askoufis
commented
Mar 26, 2026
| path.join(__dirname, 'example', 'external-config', 'dist', 'SVG_logo.svg'), | ||
| 'utf8', | ||
| ); | ||
| t.assert.fileSnapshot(output, 'snapshots/external-config.svg', { |
Contributor
Author
There was a problem hiding this comment.
File snapshots allow you to see proper syntax highlighting in a real file, simplify the testing process (if you ever need to update snapshots), and facilitate both visual and syntax diffing in GitHub.
Member
|
Thank you for the work! Looks good! Will release a new version to NPM soon |
Contributor
Author
|
@rpominov Thanks for the quick turnaround ❤️ |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svgodep to v4. AFAICT no changes are necessary within the loader.prettierto make code formatting consistent across all fileswebpack-clidepThe only files that have more than just formatting changes are:
.github/workflows/ci.yamlindex.test.jspackage.jsonSeems like a straightfoward update to me, though will obviously be breaking as
svgo@4had various breaking changes.I updated CI to use Node 22 and 24, mainly because it allowed me to use the Node
fileSnapshotAPI, which is convenient because updating asserts manually was proving to be a pain. I don't see that much value testing against older node versions assvgo's supported version(s) will ultimately dictate what this loader can support too.