Skip to content

chore(sv): refactor old code (WIP) #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sacrosanctic wants to merge 2 commits into
base: version-1
Choose a base branch
from
Draft

chore(sv): refactor old code (WIP) #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01e771
use `ROOT`
sacrosanctic Sep 9, 2026
f453f56
no period in error messages
sacrosanctic Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sv/src/create/playground.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export function setupPlaygroundProject(
installDependencies: boolean
): void {
const mainFile = playground.files.find((file) => file.name === 'App.svelte');
if (!mainFile) throw new Error('Failed to find `App.svelte` entrypoint.');
if (!mainFile) throw new Error('Failed to find `App.svelte` entrypoint');

const dependencies = detectPlaygroundDependencies(playground.files);
for (const file of playground.files) {
Expand Down
9 changes: 7 additions & 2 deletions packages/sv/src/create/scripts/build-templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import fs from 'node:fs';
import { createRequire } from 'node:module';
import path from 'node:path';
import * as find from 'empathic/find';
import parser from 'gitignore-parser';
import { format } from 'oxfmt';
import { transform } from 'sucrase';
import oxfmtConfig from '../../../../../oxfmt.config.ts';

/** @import { File, LanguageType } from '../index.ts' */

const pnpmWorkspace = find.up('pnpm-workspace.yaml', { cwd: import.meta.dirname });
if (!pnpmWorkspace) {
throw new Error("This project must have a 'pnpm-workspace.yaml' file");
}
const ROOT = path.dirname(pnpmWorkspace);
const pkgRoot = path.resolve(import.meta.dirname, '..');
const require = createRequire(import.meta.url);
const createVitePath = path.dirname(require.resolve('create-vite/package.json'));
Expand Down Expand Up @@ -94,9 +100,8 @@ async function generate_templates(dist, shared) {
// to be able to develop and deploy the app from here, but have a different
// package.json in newly created projects (based on package.template.json)
if (name === 'package.template.json') {
const packagesDir = path.resolve(pkgRoot, '..', '..', '..');
const getVersion = (/** @type {string} */ pkgDir) => {
const pkgPath = path.join(packagesDir, pkgDir, 'package.json');
const pkgPath = path.join(ROOT, 'packages', pkgDir, 'package.json');
return JSON.parse(fs.readFileSync(pkgPath, 'utf8')).version;
};
const replaceWorkspace = (
Expand Down