refactor(firewall): rename to Security Group - #8
Open
r-gues wants to merge 1 commit into
Open
Conversation
Match the backend rename shipped in superphenix 2ca0031. Wire contract: - endpoint /firewall -> /security-group - response wrapper field firewall -> securityGroup - product type discriminator firewall -> securityGroup - ProjectFirewallRead/Write -> ProjectSecurityGroupRead/Write Request bodies are structurally unchanged: general/spec, target, ingress, egress, ports, from, to, allowAll, denyAll, matchLabels, matchExpressions, podSelector and IPBlock/CIDR/Except keep their JSON names. Code and user-facing labels renamed throughout: 05_firewall -> 05_security_group, models/network/firewall -> models/network/security-group, FirewallService -> SecurityGroupService, Firewall* -> SecurityGroup* components and spx-security-group-* selectors. All visible strings now read "Security Group". Backwards compatibility for URLs predating the rename: - a legacy 'firewall' route redirects to 'security-group', preserving child segments and :az/:id params (covered by network.routes.spec.ts) - ProductTypeLink keeps a 'firewall' alias so previously shared /redirect/.../firewall/<id> links still resolve; that entry point goes through getProduct(), which a router redirect cannot cover localStorage keys become security_group_show_cluster / security_group_refresh with no migration: they are UI toggles, so users get defaults once. KaaS keeps the /netpols endpoint path and its "Network Policies" wording (the Kubernetes concept), but is now gated by ProjectSecurityGroupRead. Behaviour change beyond the rename: the route guard checked ProjectLoadBalancerRead due to a copy-paste bug and now checks ProjectSecurityGroupRead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends https://github.com/super-phenix/superphenix/pull/92
Rename firewall to security group alongside API and permissions usages