fix: restore sqlite3 -line output separator#63
Open
blob42 wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for this patch! 💖 There is an unrelated Makefile addition bundled in this patch: would you mind extracting that out into a separate patch to keep this focused? Cheers. |
Author
|
@sunaku sure I added it by mistake |
sqlite3 3.50+ changed -line mode separator from ' = ' to ': '. Downstream awk parsers expect ' = ' format. Explicitly set -separator to restore compatibility.
blob42
force-pushed
the
fix-sqlite3-line-separator
branch
from
d63af26 to
bf50b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlite3 3.50+ changed
-linemode separator from=to:.Downstream awk parsers in
dasht-query-lineanddasht-query-htmlexpectkey = valueformat. The\ == "="match never fires with colon separator, producing empty results.Add explicit
-separator ' = 'to sqlite3 call indasht-query-execto restore compatibility.