translator_sv2: BIP323 version rolling mask - #656
Merged
plebhash merged 2 commits intoAug 4, 2026
Merged
Conversation
plebhash
changed the title
translator_sv2: BIP323 version rolling mask
plebhash
marked this pull request as draft
July 31, 2026 22:46
plebhash
force-pushed
the
2026-07-31-bip323-sv1-api-translation
branch
4 times, most recently
from
August 3, 2026 16:18
fd2d031 to
8a6f1f9
Compare
Use sv1_api::utils::VERSION_ROLLING_MASK (0x1FFFFFE0) instead of the hardcoded BIP320 value 0x1FFFE000 in two places: - downstream_message_handler.rs: mask negotiation in handle_configure - utils.rs: default mask in validate_sv1_share This allows version rolling of bits 5-12, extending the BIP320 range (13-28) to the full BIP323 range (5-28).
plebhash
force-pushed
the
2026-07-31-bip323-sv1-api-translation
branch
from
August 4, 2026 13:36
8a6f1f9 to
acf8743
Compare
plebhash
force-pushed
the
2026-07-31-bip323-sv1-api-translation
branch
from
August 4, 2026 14:11
acf8743 to
8d9f18d
Compare
plebhash
marked this pull request as ready for review
August 4, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion stratum-mining/stratum#2237