Repository navigation
fix(types): use portable string literal aliases - #902
Open
oriori1703 wants to merge 1 commit into
Open
oriori1703 wants to merge 1 commit into
oriori1703 wants to merge 1 commit into
Conversation
This was referenced Oct 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conform.LspFormatOptsdefault_format_opts.lsp_formatvaluesLuaLS understands both the previous nested-quote spelling and the direct literal spelling. EmmyLua only interprets the direct spelling as the actual Lua string value.
Verification
emmylua_check 0.25.1: valid values accepted and invalid values rejectedlua-language-server 3.19.1: valid values accepted and invalid values rejectedsetup { default_format_opts = { lsp_format = 'fallback' } }call accepted by both analyzersgit diff --checkmake testwas also run. Two unrelated newline-preservation tests fail under Neovim 0.12.5 (fuzzer formats correctlyandrunner e2e sets the correct output); all other tests pass.make lintcould not complete becauseluacheckis not installed in the environment.Related: EmmyLuaLs/emmylua-analyzer-rust#1271