Skip to content

fix: emit a real edit when inserting past the last line #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfvelten wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −4
Open

fix: emit a real edit when inserting past the last line #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lua/conform/runner.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,19 @@ local function create_text_edit(
end
end
-- If we're inserting text, make sure the text includes a newline at the end.
-- The one exception is if we're inserting at the end of the file, in which case the newline is
-- implicit
if is_insert and start_line < #original_lines then
table.insert(replacement, "")
if is_insert then
if start_line < #original_lines then
table.insert(replacement, "")
else
-- We're inserting past the last line. A zero-width edit on a line that doesn't exist yet is a
-- no-op, so anchor the edit to the end of the last line and lead with the newline instead.
local last_line = original_lines[#original_lines] or ""
start_line = #original_lines - 1
end_line = start_line
start_char = #last_line
end_char = start_char
table.insert(replacement, 1, "")
end
end
local new_text = table.concat(replacement, line_ending)

Expand Down
Loading