feat: track Cursor local storage#1447
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 11, 2026, 11:39 PM ET / 03:39 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 9b22e65bbc91. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
4440710 to
f4649ee
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4649eef22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| homePath("Library/Caches/Cursor"), | ||
| homePath("Library/Caches/com.todesktop.230313mzl4w4u92"), | ||
| homePath("Library/Caches/com.todesktop.230313mzl4w4u92.ShipIt"), | ||
| homePath("Library/Caches/cursor-compile-cache"), |
There was a problem hiding this comment.
Include Cursor's updater cache root
This cache list still misses Cursor's updater payload directory at ~/Library/Application Support/Caches/cursor-updater (I checked the current macOS Cursor uninstall/cleanup recipe, which removes it separately from ~/Library/Application Support/Cursor and the ~/Library/Caches/com.todesktop.* roots). When a failed or pending updater download is what is consuming space, the optional storage footprint will underreport Cursor's local usage even though this change says it tracks the updater caches.
Useful? React with 👍 / 👎.
f4649ee to
f6bc243
Compare
f6bc243 to
02294e3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02294e3411
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| homePath("Library/Caches/com.todesktop.230313mzl4w4u92"), | ||
| homePath("Library/Caches/com.todesktop.230313mzl4w4u92.ShipIt"), | ||
| homePath("Library/Caches/cursor-compile-cache"), |
There was a problem hiding this comment.
Include Cursor HTTP storage caches
On macOS installs where Cursor's ToDesktop shell accumulates response cache data under ~/Library/HTTPStorages/com.todesktop.230313mzl4w4u92 (the current Cursor macOS cleanup recipe removes ~/Library/HTTPStorages/com.todesktop.* alongside these ToDesktop cache roots), this new catalog still reports little or no Cursor storage after the listed paths are scanned. Since the feature is meant to account for Cursor's local caches, add the matching HTTPStorages root so the optional footprint does not underreport users' local Cursor data.
Useful? React with 👍 / 👎.
Summary
Closes #1403.
Proof
swift test --filter ProviderStorageFootprintTests— 16/16 passedmake check— SwiftFormat/SwiftLint cleangpt-5.5, confidence 0.86)com.todesktop.230313mzl4w4u92and.ShipItcache rootsRisk
Low. Storage tracking is opt-in, scans on the existing detached utility-priority path, and remains read-only.