fix: use Cursor app auth as fallback#1295
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 12, 2026, 7:43 AM ET / 11:43 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 2cd2fe15a56a. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69bf8e7407
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Thanks for the automated review — both points were valid and are addressed in Changes:
Validation:
|
|
@clawsweeper re-review Addressed the code findings:
Validation is in the PR body. Live provider proof is still not run here because AGENTS.md requires an explicit request before real credential/provider probes. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review Please review current head |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
|
@clawsweeper re-review Added redacted live Cursor.app local-auth proof to the PR body for current head Proof summary:
|
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
148048d to
15b6cb2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15b6cb217a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
15b6cb2 to
94e0c27
Compare
94e0c27 to
4e85cae
Compare
|
Rebased current head onto
Current head: |
4e85cae to
aa4a25b
Compare
Summary
Test Plan
swift test --filter CursorStatusProbeTests- 38 tests passedswift test --filter CursorLoginRunnerTests- 3 tests passedmake check- SwiftFormat clean, SwiftLint 0 violationsgit range-diff; three focused maintainer safety commits addedExact-Head Live Validation
Validated commit
aa4a25bae45a66a280c38aa2a3b77bde61a93a62using the real local Cursor.app session and production Cursor endpoints. The temporary probe printed only redacted booleans and aggregate usage values; no token, account identifier, name, or email was exposed.This proves successful app-token loading, first-party web-session derivation, authenticated usage retrieval, account metadata retrieval, and billing-cycle parsing on the exact pushed head. The account is not a legacy request-quota plan, so the request-quota field is correctly absent; that path is covered by focused regression tests.