Typing dots keep the messaging contract; roster chip loses its dot - #52
Merged
Conversation
Typing means composing something you haven't seen yet: the dots now disappear the moment the agent's reply lands for this turn and stay gone through the turn's tail — the stop-gate checks and teardown that kept them pulsing after the answer arrived read as 'more is coming' when nothing was. Presence entries carry the turn's start time so a reply is attributed to its own turn and an earlier turn's reply never suppresses the next one's dots. The roster chip drops its status dot; there were dots everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field feedback: (1) the roster pill had a status dot on top of everything else pulsing — removed; (2) the typing indicator kept showing after the reply arrived, tracking the turn's stop-gate tail, which reads as 'more messages coming'. Now 'typing' means composing something you haven't seen yet: presence entries carry the turn's start time, and the dots hide permanently for a turn once the engaged agent's reply (message newer than the turn start) lands — teardown activity cannot resurrect them, and an earlier turn's reply never suppresses a new turn's dots. Pre-0.28.1 servers (no start time on the entry) keep the previous behavior. typecheck + 545 tests green, including the resurrect-after-reply regression.