fix: system theme follows OS + window chrome, invite snapshot checkbox, room copy - #49
Merged
Conversation
The window was pinned `theme: "Dark"`, which forces the webview's prefers-color-scheme to dark — so the theme selector's "system" mode could never resolve to light in the packaged app (the browser demo, with no such pin, always worked). Drop the pin so the webview tracks the OS. Then drive the native window chrome from the selector: an explicit Light/Dark forces the window to match; "system" resets it to null so the title bar and traffic lights track the OS in lockstep with the in-app theme. Needs core:window:allow-set-theme.
Replace the Snapshot-first/Skip ToggleButton with the house Checkbox component — 'Snapshot the container first', on by default. Unchecking sends snapshot:false, exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small round of UX fixes.
System theme + window chrome (app only)
The window was pinned
theme: "Dark", forcing the webview'sprefers-color-schemeto dark, so the theme selector's System mode could never resolve to light in the packaged app (the browser demo always worked). Drop the pin. Then drive the native window chrome from the selector: an explicit Light/Dark forces the window to match; System resets it tonullso the title bar + traffic lights track the OS in step with the in-app theme. Addscore:window:allow-set-theme.Invite modal snapshot control
The Snapshot-first/Skip
ToggleButtonbecomes the house Checkbox — "Snapshot the container first", on by default. Unchecking sendssnapshot: false, exactly as before.Create-room copy
Simpler, and no em-dash: "Give the room a title to start. You can add the details later." (both the create form and the empty state).
Verification
bun run typecheckclean; 517 tests green (invite skip-snapshot test drives the checkbox now).