Repository navigation
Migrate Android modules to AGP built-in Kotlin [CLF-657] - #1587
Merged
zach-klippenstein merged 4 commits intoOct 29, 2026
Merged
zach-klippenstein merged 4 commits into
zach-klippenstein merged 4 commits into
Conversation
AGP 9 compiles Kotlin itself, so applying org.jetbrains.kotlin.android
triggers a "no longer required" warning on every Android module during
Gradle sync. Re-enable built-in Kotlin and stop applying the KGP Android
plugin from the convention plugin and the two com.android.test benchmarks.
The convention plugin's ID changes from kotlin-android to
kotlin-android-conventions: AGP calls findPlugin("kotlin-android") to read
the KGP version for compiler plugin artifacts, and our plugin shadowed it,
so Compose and parcelize resolved with an empty version.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zach-klippenstein
enabled auto-merge
October 28, 2026 21:31
tcmulcahy
approved these changes
Oct 28, 2026
zach-klippenstein
disabled auto-merge
October 28, 2026 23:12
…-agp-built-in-kotlin
zach-klippenstein
enabled auto-merge
October 28, 2026 23:12
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-agp-built-in-kotlin
zach-klippenstein
disabled auto-merge
October 29, 2026 02:21
zach-klippenstein
deleted the
zachklipp/clf-657-migrate-workflow-kotlin-to-agp-built-in-kotlin
branch
October 29, 2026 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle sync warned on every Android module: "The 'org.jetbrains.kotlin.android' plugin in project ':workflow-ui:radiography' is no longer required for Kotlin support since AGP 9.0." This turns AGP 9's built-in Kotlin back on and stops applying the KGP Android plugin.
gradle.properties: dropandroid.builtInKotlin=false.android.newDsl=falsestays; the new DSL is a separate migration.KotlinAndroidConventionPluginno longer appliesorg.jetbrains.kotlin.android. It still applies the shared Kotlin settings (toolchain, explicit API,wf1-module names, warnings as errors), which AGP's built-in compile tasks pick up.com.android.testbenchmarks drop their directorg.jetbrains.kotlin.androidline.shardConnectedChecksused the KGP plugin to find Android projects; it now checks AGP's plugin IDs.The convention plugin's ID changes from
kotlin-androidtokotlin-android-conventions.kotlin-androidis also KGP's legacy plugin ID, and AGP's built-in Kotlin callsfindPlugin("kotlin-android")to read the KGP version for compiler-plugin artifacts. With our plugin registered under that ID, AGP got no version back and Compose and parcelize failed to resolve (kotlin-compose-compiler-plugin-embeddable:with an empty version). That rename is why most build scripts appear in the diff.Remaining sync warnings are pre-existing: the
android.newDsl=falsedeprecation and the matchingandroid { }accessor deprecations.Testing
./gradlew help --warning-mode=allconfigures every project with no "no longer required" warnings../gradlew assembleDebug assembleDebugAndroidTest compileDebugUnitTestKotlinsucceeds.:workflow-tracing:testDebugUnitTestpasses.ktfmtCheckpasses for the main build andbuild-logic.🤖 Generated with Claude Code